Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use major version instead of exact version #21

Merged
merged 1 commit into from
Mar 19, 2023
Merged

Use major version instead of exact version #21

merged 1 commit into from
Mar 19, 2023

Conversation

Apacelus
Copy link
Contributor

Only set the major version to "force" "copy-paste" users to always use the latest version of the action by default.

This should avoid the need to delete older releases like what happened in #20

Only set the major version to "force" "copy-paste" users to always use the latest version of the action by default.
@thadguidry
Copy link
Collaborator

This works but only in the context of the current situation. But thanks, I'll merge this.

@thadguidry thadguidry merged commit 0885ecc into dev-drprasad:master Mar 19, 2023
@Apacelus
Copy link
Contributor Author

@thadguidry so this doesnt seem to work, neither with @v0.2, nor @v0 (or @v2).
Seems like you have to enable something as described here

@thadguidry
Copy link
Collaborator

thadguidry commented Mar 20, 2023

WHAT specifically is not working for you. Can you give me some reproducible steps you are doing? or show me your workflow?

If you were trying to solve a problem of "force users to always use the latest version".
Then that problem is the problem I solved in the only way that is possible - break semantic version guarantees by removing older versions.
If you were trying to solve a problem of "warn users to always use the latest version".
Then that problem is not a problem to solve because notifications, as far as I understand, are not sent to workflow users of an Action, they might see a notice in their logs, but I don't think that happens and have not seen docs that explain if that happens or not. https://docs.github.com/en/actions/creating-actions/releasing-and-maintaining-actions

If you have found something that differs from my above understanding, then I'll be happy to review the docs.

@thadguidry
Copy link
Collaborator

My method of forcing users (breaking old workflows that have a semantic version guarantee - whereby I deleted prior version tags) is unpopular by many users in this circumstance, but it's the only way to truly force users to move forward.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants