Added keepAlive option. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on this pull request as it is a blocker for us using Selenium, GhostDriver and PhantomJS in our Django test suites. Now having to fall back on Firefox. ;-( |
|
Looking into this now... |
|
I have removed the |
AkeemMcLennon
pushed a commit
to AkeemMcLennon/ghostdriver
that referenced
this pull request
Feb 23, 2015
CHANGELOG for v1.1.0 (https://github.com/detro/ghostdriver/issues?labels=1.1.0&state=closed) JavaScript Driver (Core) * ENHANCEMENT: `/maximize` window will set the window size to 1336x768, currently most common resolution online (see http://gs.statcounter.com/#resolution-ww-monthly-201307-201312) * ENHANCEMENT detro#275: Implemented Browser and Network (HAR) Logging types * FIXED #284: Attempt to wait for Page to Load if input causes form submit * FIXED #291: Throw exception when attempting to set invalid timeout value * FIXED detro#259: Fix issue regarding mouse clicks * ENHANCEMENT detro#290: Enabled support for "Keep Alive" HTTP connections * ENHANCEMENT detro#262: Allow access to PhantomJS API from WebDriver (Driver part) * ENHANCEMENT #293: Import Selenium 2.39.0 WebDriver Atoms Java Binding * MINOR detro#251: Minor compilation issues for Binding * ENHANCEMENT detro#262: Allow access to PhantomJS API from WebDriver (Java Binding part) Tested using GhostDriver validation tests (https://github.com/detro/ghostdriver/tree/master/test). ariya/phantomjs#11877
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the use of the latest version of Selenium with PhantomJS & GhostDriver in that Selenium was recently changed to use keep-alive for remote connections, now assuming that the WebDriver connection supports keep-alive and that it can leave the socket open. Unfortunately, by default, keep-alive is disabled in PhantomJS, creating an issue when the two are used together in which GhostDriver closes the HTTP connection while Selenium has requested it remain open.
I've developed a fix in the form of adding a command line argument to PhantomJS that enables keep-alive in GhostDriver. This is the first part of that fix in the form of adding a
keepAliveoption to GhostDriver that can be called from PhantomJS based on the value of the command line argument.I assume the protocol would be to get this merged to ghostdriver/master, wait for the changes to be added to the PhantomJS repo, and then submit a pull request on the PhantomJS repo for the changes involving the command line argument. Any clarification on the process would be appreciated 😄