ethers v4 and v5 overload behavior fixes & tests #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krzkaczor this passes all the tests for me. I just merged Also merged in master to make sure all was still well. Looks good. Should be good to merge with #252 then to master but lmk if any issues on your end. The behavior change is a bit annoying :-P but what can ya do... ethers-io/ethers.js#407 (comment) |
bradennapier
changed the title
krzkaczor
approved these changes
Aug 2, 2020
|
This looks great. Thanks for you work @bradennapier! I will publish new packages probably tmrw. |
|
Sounds good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets try this PR
This incorporates the already merged PR's as well as #256 with the conflict fixes. Should work with the tests.
I think the reason the tests failed were something I fixed in this PR but its been awhile so I forget. Either way, all the tests seem to be passing :-)
I am quite certain this is the right behavior as I dug into the ethers code on both v4 and v5 after noticing the comments mentioned the differences in that issue I linked. LMK if anything seems amiss.