chore: consolidate k8s informers code & fix Makefile mocks #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Comment on lines
137
to
150
| func (i *informer) run() { | ||
| ctx, cancel := context.WithCancel(context.TODO()) | ||
| i.syslog.Debugf("%s informer is starting", i.name) | ||
| for { | ||
| select { | ||
| case event := <-i.resultChan: | ||
| if event.Type == watch.Error { | ||
| i.syslog.Warnf("%s informer emitted error %+v", i.name, event) | ||
| continue | ||
| } | ||
| i.cb(event) | ||
| cancel() | ||
| case <-ctx.Done(): | ||
| panic(fmt.Sprintf("%s informer stopped unexpectedly: %s", i.name, ctx.Err())) | ||
| } |
There was a problem hiding this comment.
Issue here -- placing the cancel() call causes informer to crash sooner than desired.
There was a problem hiding this comment.
reverted because informers crash with this implementation
There was a problem hiding this comment.
we shouldn't be calling cancel in the informer run loop.
i would've just made run() take a context like run(ctx context.Context), pass context.TODO() for now in the pods actor, and then in tests, at the top of each test
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
and use that context in the run calls in the test
carolinaecalderon
changed the title
carolinaecalderon
force-pushed
the
9686-consolidate-informers
branch
from
4bdfb33 to
bde62bf
Compare
carolinaecalderon
force-pushed
the
9686-consolidate-informers
branch
from
8b501c2 to
0bb844b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After removing the actor system from the k8s informers code, refactor the pod/node/event/preemption informer code to remove redundancies & consolidate (if possible) to fewer functions. (This PR would reduce that code by 40%, yay!)
Each informer defines its own "callback function", but now these callback functions are standardized to accept
watch.Events (vs other struct types). This additionally standardizes therun()function.Since each informer constructor calls on/returns different types, the
newInformer()- type functions could not be combined. (The exception is withpod-Informerandpreemption-Informer, both of which deal with pod lists).Also -- this PR adds code to generate the Pod/EventInterface mocks.
Test Plan
Test in the a similar manner as #7182 and #7256.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
DET-9686