feat: support agent on Apple Silicon without Rosetta #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for determined-ui ready! 🔨 Explore the source changes: 8a7ae1b 🔍 Inspect the deploy log: https://app.netlify.com/sites/determined-ui/deploys/61baaa2fd91b130008871d3b 😎 Browse the preview: https://deploy-preview-3328--determined-ui.netlify.app/ |
ioga
approved these changes
Dec 16, 2021
mpkouznetsov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Agent exits on Apple with M1 chip because of an error when obtaining the CPU info using gopsutil ( shirou/gopsutil#1000 ). This PR works around the error by providing placeholder values for brand and UUID.
Test Plan
Start Agent successfully on M1 Mac.
Commentary (optional)
We may choose to wait for the fix to gopsutil or we can merge this fix now and replace it with an upgrade of gopsutil when a fix becomes available there.
Checklist
docs/release-notes/.See Release Note for details.