Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update CI setup for running GPU unit tests #10230

Merged
merged 21 commits into from
Nov 22, 2024
Merged

Conversation

jgongd
Copy link
Contributor

@jgongd jgongd commented Nov 21, 2024

Ticket

Description

test-unit-harness-gpu-tf, test-unit-harness-pytorch2-gpu, test-unit-harness-gpu-parallel, and test-unit-harness-gpu-deepspeed were ran on:

  • determined-ai/container-runner-gpu
  • determined-ai/container-runner-multi-gpu

These runners were hosted on https://console.cloud.google.com/kubernetes/clusters/details/us-central1/ci-runners-cluster. We no longer have ci-runners-cluster on GCP. Use GPU instance on CircleCI instead.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@jgongd jgongd requested a review from a team as a code owner November 21, 2024 22:47
@jgongd jgongd requested a review from mackrorysd November 21, 2024 22:47
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4bbc843
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/673ff2a928435a000872ccca

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.35%. Comparing base (81b2fce) to head (4bbc843).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10230      +/-   ##
==========================================
+ Coverage   53.67%   54.35%   +0.68%     
==========================================
  Files        1255     1256       +1     
  Lines      155754   155779      +25     
  Branches     3617     3618       +1     
==========================================
+ Hits        83607    84681    +1074     
+ Misses      72014    70965    -1049     
  Partials      133      133              
Flag Coverage Δ
backend 45.83% <ø> (+<0.01%) ⬆️
harness 71.26% <ø> (+3.89%) ⬆️
web 54.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

---- 🚨 Try these New Features:

@jgongd jgongd changed the title CI for GPU Unit Tests ci: CI for GPU Unit Tests Nov 21, 2024
@jgongd jgongd changed the title ci: CI for GPU Unit Tests chore: CI for GPU Unit Tests Nov 21, 2024
@jgongd jgongd changed the title chore: CI for GPU Unit Tests test: Update CI setup for running GPU Unit Tests Nov 21, 2024
@jgongd jgongd changed the title test: Update CI setup for running GPU Unit Tests test: update CI setup for running GPU unit tests Nov 21, 2024
@jgongd jgongd force-pushed the jgong/ci-for-unit-tests branch from 3549132 to 4bbc843 Compare November 22, 2024 02:55
@mackrorysd mackrorysd merged commit 821e8a5 into main Nov 22, 2024
81 of 93 checks passed
@mackrorysd mackrorysd deleted the jgong/ci-for-unit-tests branch November 22, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants