Repository navigation
Repair wp/5.5 branch Actions: Stop the puppeteer alias from changing package-lock.json - #691
Closed
desrosj wants to merge 2 commits into
Conversation
desrosj
added this pull request to stack #692
October 8, 2026 18:11
desrosj
removed this pull request from stack #692
October 9, 2026 19:59
desrosj
changed the base branch from
fix-actions-5.5/docker-compose-v2
to
wp/5.5
October 9, 2026 20:00
desrosj
force-pushed
the
fix-actions-5.5/fix-puppeteer-alias-lockfile-drift
branch
from
October 9, 2026 20:01
4d68cff to
cd16fb3
Compare
desrosj
changed the base branch from
wp/5.5
to
fix-actions-5.5/remove-global-axe-e2e-check
October 9, 2026 20:02
desrosj
added this pull request to stack #723
October 9, 2026 20:02
desrosj
marked this pull request as ready for review
October 16, 2026 17:12
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
removed this pull request from stack #723
October 16, 2026 17:36
desrosj
added this pull request to stack #739
October 16, 2026 17:36
desrosj
force-pushed
the
fix-actions-5.5/fix-puppeteer-alias-lockfile-drift
branch
from
October 16, 2026 17:46
cd16fb3 to
67ff6fb
Compare
Owner
Author
|
Moved to WordPress#85001. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Two commits:
@types/mime-types(2.1.1) and@types/yauzl(2.9.2) exactly in the rootdevDependencies, at the versions already inpackage-lock.json. npm drops"optional": truefrom the@types/yauzlentry, since it is now a direct dependency.puppeteeralias inpackage-lock.jsonto the versions npm resolves today:debug4.4.3,mime-db1.52.0,mime-types2.1.35,ms2.1.3,pump3.0.4,readable-stream3.6.2,tar-fs2.1.5 andws7.5.13, plus sha512 integrity forfd-slicerandyauzl.Why?
The "Static Analysis" job runs
npm installand thennpm run check-local-changes, which fails becausenpm installrewritespackage-lock.json.package.jsondeclares Puppeteer through an npm alias ("puppeteer": "npm:puppeteer-core@3.0.0"). npm 6 doesn't keep the locked versions of an aliased package's dependencies: on every install it re-resolves them to the newest versions their ranges allow, so the lockfile changes whenever one of them publishes a release. Trunk has no such alias.Pinning holds the top-level
@typesentries for good. The other entries are nested under the alias because other packages use older major versions at the top level, so they can't be pinned the same way (overridesneeds npm 8.3+), and they will need updating again when they publish new releases in range.How?
Both commits contain exactly what npm 6.14.18 (Node 14, as in CI) writes:
npm install --package-lock-onlyreproduces CI's lockfile diff line for line, and a second run on the result leaves the lockfile unchanged. Placed above #313, the last PR below this one that changespackage-lock.json.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code