Skip to content

Repair wp/6.4 branch Actions: Fix flaky interactivity router navigate e2e test - #561

Closed
desrosj wants to merge 1 commit into
fix-actions-6.4/stabilize-site-editor-perf-testsfrom
fix-actions-6.4/fix-flaky-router-navigate-test
Closed

desrosj wants to merge 1 commit into
fix-actions-6.4/stabilize-site-editor-perf-testsfrom
fix-actions-6.4/fix-flaky-router-navigate-test

Conversation

@desrosj

@desrosj desrosj commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

What?

Makes the "should update the HTML only for the latest navigation" test in test/e2e/specs/interactivity/router-navigate.spec.ts wait until the browser has requested both linked pages before letting either request through.

Why?

The test holds each page request in a page.route() handler, and the functions that let a request through (resolveLink1 and resolveLink2) are only assigned once those handlers run. The test only waited for the page's own navigation counter, which can reach 2 before Playwright has run the handlers, so calling resolveLink2() could fail with TypeError: resolveLink2 is not a function. This branch has the same race in its copy of the test, so the fix is included for consistency with the wp/7.1–wp/6.8 stacks.

Upstream

A straight cherry-pick of e693c18 (WordPress#80178) from trunk.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj desrosj self-assigned this Sep 28, 2026
@desrosj
desrosj added this pull request to stack #555 September 28, 2026 18:32
@desrosj
desrosj marked this pull request as ready for review September 28, 2026 18:36
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #555 September 28, 2026 18:59
@desrosj
desrosj changed the base branch from fix-actions-6.4/stabilize-site-editor-perf-tests to wp/6.4 September 28, 2026 18:59
@desrosj
desrosj force-pushed the fix-actions-6.4/fix-flaky-router-navigate-test branch from 032959d to 057f27c Compare September 28, 2026 19:00
@desrosj
desrosj changed the base branch from wp/6.4 to fix-actions-6.4/stabilize-site-editor-perf-tests September 28, 2026 19:01
@desrosj
desrosj added this pull request to stack #565 September 28, 2026 19:01
@desrosj

desrosj commented Sep 28, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#83692. The branch is left in place.

@desrosj desrosj closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant