Skip to content

Repair wp/6.6 branch Actions: Remove the broken flaky-test-to-GitHub-issues reporting job - #131

Closed
desrosj wants to merge 1 commit into
fix-actions-6.6/fix-wp-env-debian-busterfrom
fix-actions-6.6/disable-flaky-test-issue-reporting
Closed

desrosj wants to merge 1 commit into
fix-actions-6.6/fix-wp-env-debian-busterfrom
fix-actions-6.6/disable-flaky-test-issue-reporting

Conversation

@desrosj

@desrosj desrosj commented Aug 31, 2026

Copy link
Copy Markdown
Owner

What?

Removes end2end-test.yml's report-to-issues job, which posts flaky end-to-end test summaries as GitHub issues, along with the has-flaky-test-report output on merge-artifacts that fed it (its only consumer).

Why?

report-to-issues does actions/checkout … ref: trunk before building and running ./packages/report-flaky-tests — so it never runs this branch's own frozen copy of the action, it runs whatever is on live current trunk at the time the job happens to execute. Trunk has since retired the npm run build:packages script this job's "Npm build" step calls, as part of migrating report-flaky-tests to run directly from TypeScript source via Node 24's native type-stripping (WordPress/gutenberg#81218, "Flaky tests: Report as a PR comment only, stop creating issues").

Reproducing the job's own build command against trunk's current package.json confirms the exact failure:

npm error Missing script: "build:packages"

This branch's most recent end2end-test.yml run (fix-actions-6.6/fix-wp-env-debian-buster, run 33230071941) happened to have this job report as skipped rather than failure, because the upstream e2e-playwright jobs failed outright and no flaky-tests-report artifact was ever produced for merge-artifacts to hand off — but the underlying breakage is unconditional: any time the job's guard condition (needs.merge-artifacts.outputs.has-flaky-test-report == 'true') is met, it will fail with the error above, since it depends on a script that no longer exists on trunk.

Because the job tracks a moving target (trunk) instead of this branch's own commit, it will keep breaking in step with trunk's tooling regardless of anything on this frozen, security-maintenance-only branch — this is a structural failure mode, not a one-time regression.

Retrofitting the job to match trunk's current implementation was considered and rejected: trunk's replacement is not just a CI fix but a product-policy change (flaky tests are now reported as PR comments instead of filed as GitHub issues), which is out of scope for a security-maintenance branch. Removing the job only drops an automated notification; it has no effect on actual test-correctness signal, since it never gated the build and only ever posted flaky-test summaries as GitHub issues.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj removed this pull request from stack #91 September 10, 2026 19:36
@desrosj
desrosj force-pushed the fix-actions-6.6/disable-flaky-test-issue-reporting branch from 351da83 to 1fa4f58 Compare September 10, 2026 19:37
@desrosj
desrosj added this pull request to stack #186 September 10, 2026 19:37
@desrosj
desrosj force-pushed the fix-actions-6.6/disable-flaky-test-issue-reporting branch from 1fa4f58 to aaf8c3f Compare September 10, 2026 23:55
@desrosj
desrosj force-pushed the fix-actions-6.6/disable-flaky-test-issue-reporting branch from aaf8c3f to 48658e9 Compare September 11, 2026 00:30
@desrosj
desrosj force-pushed the fix-actions-6.6/disable-flaky-test-issue-reporting branch from 48658e9 to 90420c7 Compare September 11, 2026 01:16
@desrosj
desrosj force-pushed the fix-actions-6.6/disable-flaky-test-issue-reporting branch from 90420c7 to 12db32e Compare September 11, 2026 02:38
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 02:48
@desrosj
desrosj marked this pull request as draft September 11, 2026 03:22
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj force-pushed the fix-actions-6.6/disable-flaky-test-issue-reporting branch 3 times, most recently from f6c73a6 to e4eecef Compare September 14, 2026 17:39
@desrosj
desrosj force-pushed the fix-actions-6.6/disable-flaky-test-issue-reporting branch from e4eecef to a9afb0c Compare September 14, 2026 19:19
@desrosj
desrosj marked this pull request as ready for review September 14, 2026 23:59
…2end-test.yml`.

`report-to-issues` always checks out `ref: trunk` before building and running `./packages/report-flaky-tests`, so it never runs this branch's own frozen copy of the action — it runs whatever is on live current trunk at the time the job executes. Trunk has since retired the `npm run build:packages` script this job's "Npm build" step depends on, as part of migrating `report-flaky-tests` to run directly from TypeScript source via Node 24's native type-stripping (WordPress#81218, "Flaky tests: Report as a PR comment only, stop creating issues"). Reproducing the job's own command against trunk's current `package.json` confirms the exact failure:

    npm error Missing script: "build:packages"

Because the job tracks a moving target instead of this branch's own commit, it will keep breaking in step with trunk's tooling regardless of anything on this frozen, security-maintenance-only branch — this is a structural failure mode, not a one-time regression.

Retrofitting the job to match trunk's current implementation was considered and rejected: trunk's version is not just a CI fix but a product-policy change (flaky tests are now reported as PR comments instead of filed as GitHub issues), which is out of scope for a security-maintenance branch. Removing the job only drops an automated notification; it has no effect on actual test-correctness signal, since it only ever posted flaky-test summaries as GitHub issues and never gated the build.

The `has-flaky-test-report` output on `merge-artifacts` is also removed, since `report-to-issues` was its only consumer.
@desrosj
desrosj force-pushed the fix-actions-6.6/disable-flaky-test-issue-reporting branch from a9afb0c to 60b070a Compare September 15, 2026 00:11
@desrosj
desrosj removed this pull request from stack #186 September 15, 2026 00:25
@desrosj
desrosj added this pull request to stack #354 September 15, 2026 00:26
@desrosj

desrosj commented Sep 15, 2026

Copy link
Copy Markdown
Owner Author

Migrated to real upstream: WordPress#82921. Closing this fork PR.

@desrosj desrosj closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant