Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with random endpoint selection after series of sets for interface/configuration #98

Conversation

mkozaaczka
Copy link
Contributor

… same pipe buffers for different endpoints. Adding code that will replace new USBPCAP_INTERNAL_ENDPOINT_INFO with old one.

Copy link
Owner

@desowin desowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reword commit message to have shorter subject line (ideally up to 50 characters) and wrap the body at 72 characters.

USBPcapDriver/USBPcapTables.c Outdated Show resolved Hide resolved
Added code that that will update USBPCAP_INTERNAL_ENDPOINT_INFO elements data.
@mkozaaczka mkozaaczka force-pushed the capturing_isochronus_transfer_occurs_form_random_endpoints branch from 4555ac9 to 5c58cf6 Compare April 15, 2020 19:48
@mkozaaczka mkozaaczka requested a review from desowin April 15, 2020 21:12
@mkozaaczka mkozaaczka changed the title After serious of set urbs for interface/configuration system my reuse… Fixed issue with random endoint selection after series set of inf/config Apr 15, 2020
@mkozaaczka mkozaaczka changed the title Fixed issue with random endoint selection after series set of inf/config Fixed issue with random endpoint selection after series set of inf/config Apr 15, 2020
@mkozaaczka mkozaaczka changed the title Fixed issue with random endpoint selection after series set of inf/config Fixed issue with random endpoint selection after series of sets for interface/configuration Apr 15, 2020
@mkozaaczka
Copy link
Contributor Author

Please review the changes.

USBPcapDriver/USBPcapTables.c Show resolved Hide resolved
USBPcapDriver/USBPcapTables.c Outdated Show resolved Hide resolved
USBPcapDriver/USBPcapTables.c Outdated Show resolved Hide resolved
@mkozaaczka mkozaaczka requested a review from desowin April 16, 2020 14:50
@mkozaaczka
Copy link
Contributor Author

is it ok now? ready to complete this pull request ?

@desowin desowin merged commit 2e535bc into desowin:master May 11, 2020
desowin pushed a commit that referenced this pull request May 11, 2020
If the same handle is reused as a result of SET INTERFACE/CONFIGURATION
series, use the latest endpoint inormation associated with the handle.
This results in correct endpoint information in captured packets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants