-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build and publish config for CommonJS #8
Add build and publish config for CommonJS #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this article and others I have read you need to remove the "type": "module"
line for it to work. I tried with those changes locally at that made it work for me.
Hi @mariusGundersen, thanks a lot for your involvement! I see, having the But they also recommend keeping |
Yes, now it works! It seems like the problem was |
Thank you for taking the time to fix this for me 🥳 |
Glad to hear that! I've also been reading a bit more about it just to make sure. According to Vite.js CJS troubleshooting what we're doing matches the "Configure ESM as default, opt-in to CJS if needed" approach, which I think is great to remain in the modern direction! I'll check everything is still working properly for ESM consumers and we'll get this published on v1.2.0. @mariusGundersen thanks for contributing! |
Fixes #6