Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix column name #193

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix column name #193

merged 1 commit into from
Jul 19, 2024

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Jul 16, 2024

Hi,

The column name seems incorrect PSF_TO_FIBER_SPECFLUX instead of PSF_TO_FIBER_FLUX. The patch fixes that.

S

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 31dd71c on fix
into b6ec059 on main.

@weaverba137
Copy link
Member

Could you please give an example file that has this column name? The data model was previously tested on EDR, so if this is something new, that's fine, but we need to verify that.

@segasai
Copy link
Contributor Author

segasai commented Jul 16, 2024

I think the problem was in the EDR as well, as I can see it in fuji and iron (and jura):
/global/cfs/cdirs/desi/spectro/redux/fuji/exposures/20210116/00072716/fluxcalib-z6-00072716.fits
/global/cfs/cdirs/desi/spectro/redux/iron/exposures/20211114/00108766/fluxcalib-r9-00108766.fits.gz

@weaverba137
Copy link
Member

Thank you, I will have to investigate further. It is possible that both column names are present in a given specprod.

@weaverba137
Copy link
Member

OK, I see what you're doing now. Thank you for noticing this. Merging now.

@weaverba137 weaverba137 merged commit d79fad0 into main Jul 19, 2024
34 checks passed
@weaverba137 weaverba137 deleted the fix branch July 19, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants