fix: Fix type error for Python 3.8 #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last-partizan
force-pushed
the
fix-type-error
branch
from
5efd5b9
to
afc9d4d
Compare
|
This brings back the issue that was fixed with #744. It seems that this was fixed for Python 3.8 which is not supported for this package anymore. Can we please revert this? |
last-partizan
added a commit
that referenced
this pull request
Sep 4, 2024
This reverts commit 5cc37c2.
|
Sure, created a PR reverting it. After i merge it, please create separate PR adding a test for get_type_hits, so we accidentally do not break it again. |
last-partizan
added a commit
that referenced
this pull request
Sep 4, 2024
|
Thanks! I'll add a test in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.