-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add component.json #426
add component.json #426
Conversation
Any reason why this was closed? We'll have to add support to Outlayer and get-size: |
It didn't work. It looks like masonry needs to be built to include the dependencies, but the dependencies aren't component-compatible from what I saw. |
Let's not give up there:
|
@RobLoach Thanks for getting the ball rolling on this. Nothing like a bunch of easy pull requests to send a jolt! ⚡ As Masonry is broken up into lots of dependencies, this will require a bit more work on my end to add the necessary CommonJS transports to make it all work together. |
@desandro Oh, that would be even more fantastic. I was just going to do it Would all of them need CommonJS? Do you know which ones are missing? Thanks a lot, |
EventEmitter now contains |
Masonry v3.2.0 officially supports CommonJS. But not Component or Duo just yet. Please +1 if you'd like to see support |
Closing this PR after no +1's for Component or Duo. |
I'd love Duo / Component support! What's needed at this point, just the component.json? Let me know, I'd be happy to help! |
So it works with github.com/component :)