Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add component.json #426

Closed
wants to merge 2 commits into from
Closed

add component.json #426

wants to merge 2 commits into from

Conversation

lancejpollard
Copy link

So it works with github.com/component :)

@RobLoach
Copy link

Any reason why this was closed? We'll have to add support to Outlayer and get-size:

@lancejpollard
Copy link
Author

It didn't work. It looks like masonry needs to be built to include the dependencies, but the dependencies aren't component-compatible from what I saw.

@desandro desandro reopened this Oct 29, 2013
@desandro
Copy link
Owner

@RobLoach Thanks for getting the ball rolling on this. Nothing like a bunch of easy pull requests to send a jolt! ⚡

As Masonry is broken up into lots of dependencies, this will require a bit more work on my end to add the necessary CommonJS transports to make it all work together.

@RobLoach
Copy link

@desandro Oh, that would be even more fantastic. I was just going to do it require them manually in my own script, but if the CommonJS is there, the more the merrier.

Would all of them need CommonJS? Do you know which ones are missing?

Thanks a lot,
Rob

@Olical
Copy link

Olical commented Nov 7, 2013

EventEmitter now contains component.json in develop. I'll be pushing it over to master as soon as I can. I just got back from a holiday, catching up on the land of OSS first.

@desandro
Copy link
Owner

Masonry v3.2.0 officially supports CommonJS. But not Component or Duo just yet. Please +1 if you'd like to see support

@desandro
Copy link
Owner

Closing this PR after no +1's for Component or Duo.

@desandro desandro closed this Jun 29, 2015
@ghost
Copy link

ghost commented Sep 6, 2015

I'd love Duo / Component support! What's needed at this point, just the component.json? Let me know, I'd be happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants