Correctly check for SDL tags and write tags to config after successful verification #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a game has a `__required` SDL which is an empty string will fail verification because the check for building the list of hashes will fail, implying that the whole game including all the SDLs will be validated. At the same time, if we are importing a game using a config file that doesn't specify the `install_tags` for such a game, the install tags won't be saved due to calling an early `exit(0)`. These two issues combined can cause a verification, repair, verification loop. This commit addresses both of those issues. Related convertation on Discord: https://discord.com/channels/695233346627698689/695234626582609940/1084939380713594924
loathingKernel
changed the title
loathingKernel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a game has a
__requiredSDL which is an empty string will fail verification because the check for building the list of hashes will fail, implying that the whole game including all the SDLs will be validated.At the same time, if we are importing a game using a config file that doesn't specify the
install_tagsfor such a game, the install tags won't be saved due to calling an earlyexit(0).These two issues combined can cause a verification, repair, verification loop. This commit addresses both of those issues.
Example game: Fallout 3
Related conversation on Discord:
https://discord.com/channels/695233346627698689/695234626582609940/1084939380713594924