Bugfix: throw exception on null value or cast it into string #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to new behaviour of PHP 8.1 it is no longer allowed to pass null values into string functions like
htmlspecialchars()
.So this causes errors while rendering TextTemplate with a message like:
htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated
.But this type of message is not really useful to find the root of the cause...
This PR changes the method
TextTemplate::_parseValueOfTags()
.Before a value is passed to the filters it will be checked and a TemplateParsingException is thrown or the value is just set to an empty string otherwise.
It depends on the new constructor's boolean parameter
$castNullIntoString
which action will be taken.I'm not sure about the default behaviour...
I personally prefer throwing an exception 'cause there might be something wrong.
Others may prefer the casting variant / overwriting null with an empty string.
@dermatthes please take a look at the changes before merging.