-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
george / Improve coverall report time execution #17537
Merged
heorhi-deriv
merged 3 commits into
deriv-com:master
from
heorhi-deriv:coverall-time-execution-workflow
Nov 22, 2024
Merged
george / Improve coverall report time execution #17537
heorhi-deriv
merged 3 commits into
deriv-com:master
from
heorhi-deriv:coverall-time-execution-workflow
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heorhi-deriv
requested review from
ali-hosseini-deriv,
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
nijil-deriv,
sandeep-deriv,
wojciech-deriv,
yashim-deriv,
hirad-deriv and
dan-deriv
as code owners
November 16, 2024 13:23
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-coverall-time-execution-889b67.binary.sx/ |
heorhi-deriv
force-pushed
the
coverall-time-execution-workflow
branch
from
November 16, 2024 13:29
a0422a1
to
2eda1f8
Compare
Pull Request Test Coverage Report for Build 11870532680Details
💛 - Coveralls |
ali-hosseini-deriv
previously approved these changes
Nov 20, 2024
heorhi-deriv
force-pushed
the
coverall-time-execution-workflow
branch
from
November 21, 2024 07:33
fc5f296
to
e7a7b42
Compare
heorhi-deriv
force-pushed
the
coverall-time-execution-workflow
branch
from
November 21, 2024 07:41
e7a7b42
to
786df97
Compare
ali-hosseini-deriv
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coveralls Workflow Improvements
Key Changes
1. Test Parallelization
Tests are now split into 10 shards (1-10)
Each shard runs in parallel, improving test execution time
Uses SHARD_INDEX and SHARD_COUNT environment variables to distribute tests
2. Build Step Optimization
Removed redundant build steps since they're already handled in another workflow
Only kept the essential components package build which is required for tests
3. Workflow Structure
Two main jobs: test (parallel test execution) and finish (coverage report finalization)
Uses Coveralls parallel execution feature to combine reports from all shards
Maintains proper job dependencies with needs: [test]