Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

george / Improve coverall report time execution #17537

Merged

Conversation

heorhi-deriv
Copy link
Contributor

@heorhi-deriv heorhi-deriv commented Nov 16, 2024

Coveralls Workflow Improvements

Key Changes

1. Test Parallelization

  • Tests are now split into 10 shards (1-10)

  • Each shard runs in parallel, improving test execution time

  • Uses SHARD_INDEX and SHARD_COUNT environment variables to distribute tests

2. Build Step Optimization

  • Removed redundant build steps since they're already handled in another workflow

  • Only kept the essential components package build which is required for tests

3. Workflow Structure

  • Two main jobs: test (parallel test execution) and finish (coverage report finalization)

  • Uses Coveralls parallel execution feature to combine reports from all shards

  • Maintains proper job dependencies with needs: [test]

Note: This optimization should result in faster CI execution while maintaining the same test coverage reporting functionality.

Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 21, 2024 8:21am

Copy link
Contributor

github-actions bot commented Nov 16, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17537](https://github.com/deriv-com/deriv-app/pull/17537)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-coverall-time-execution-889b67.binary.sx?qa_server=red.derivws.com&app_id=24078
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-coverall-time-execution-889b67.binary.sx
- **App ID**: `24078`

Copy link
Contributor

github-actions bot commented Nov 16, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-coverall-time-execution-889b67.binary.sx/

@coveralls
Copy link

coveralls commented Nov 16, 2024

Pull Request Test Coverage Report for Build 11870532680

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 53.199%

Totals Coverage Status
Change from base Build 11868243910: 0.007%
Covered Lines: 32749
Relevant Lines: 57448

💛 - Coveralls

@heorhi-deriv heorhi-deriv merged commit d15093e into deriv-com:master Nov 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants