Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for pod being controlled by other resource #132

Merged
merged 2 commits into from
Oct 31, 2020

Conversation

marians
Copy link
Contributor

@marians marians commented Sep 30, 2020

A pod that is not controlled by another resource is not resilient to nodes being terminated and other common cluster disruptions. Hence this PR adds a check with severity=2 to see whether a pod is controlled by any resource.

Preview

image

The pod has been launched using this command:

kubectl run marian-toolbox \
    --namespace marian \
    --stdin --tty \
    --restart Never \
    --rm \
    --image quay.io/marian/toolbox

TODO

  • Currently it looks as if I cannot exclude this check using this config:
popeye:
  excludes:
    v1/pods:
      - name: rx:marian
        codes:
          - 208

Any advice would be welcome.

@derailed derailed merged commit a9789f8 into derailed:master Oct 31, 2020
@derailed
Copy link
Owner

@marians Thank you for this PR! Setting the code exclusion in the spinach file seems to work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants