Fix Toggle Faults filtering #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
requested changes
Jan 30, 2024
internal/dao/workload.go
Outdated
| @@ -187,6 +188,15 @@ func diagnose(gvr client.GVR, r metav1.TableRow, h []metav1.TableColumnDefinitio | |||
| return StatusOK | |||
| } | |||
|
|
|||
| func validity(gvr client.GVR, r metav1.TableRow, h []metav1.TableColumnDefinition) string { | |||
There was a problem hiding this comment.
This ends up calling status again. Perhaps best to call it once and pass in status here to determine validity?
There was a problem hiding this comment.
Changed validity func to take status as string in the parameters.
|
@derailed Thank you for the review, changed what you requested. Let me know if something else needs to be changed still. |
Merged
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
* Added valid column to workloads for toast filtering * Removed redundant status func call, changed workload header order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Closed the previous pull request by mistake sorry)
Added extra column "VALID" into workload render, so toast can filter based on it. 2453
Also changed the name of the functions:
status->readiness
diagnose-> status
Since the column with header "STATUS" was not using the status function.