Running Job is shown in red, like the failed ones in the Jobs view
#2686
Comments
|
Slightly related to #725? |
|
Not exactly a regression, but I did some testing and up until v0.31.8 the job would stay green even when it failed. Behavior changed here in internal/render/job.go After this all pending, running and failing jobs are displayed in red |
|
Thanks for the PR #2698, @KasperHeyndrickx! |
|
Do you know if I should ping someone to get an approval for the github workflow? |
I don’t know. I can’t find easy way to see the repo’s maintainers, but here are core members listed: https://github.com/derailed/k9s?tab=readme-ov-file#meet-the-core-team |
|
The PR helped fix my problem. Using the build from it:
|
|
Thanks for confirming! |
|
Thanks you very much @KasperHeyndrickx and @derailed! |
* 'master' of github.com:derailed/k9s: (169 commits) fix: align build image Go version with go.mod (derailed#2812) Bump github.com/docker/docker (derailed#2816) Bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (derailed#2813) Add comment about Escape keybinding (derailed#2817) proper handle OwnerReference for manually created job (derailed#2772) [derailed#2773] fix freebsd build failure (derailed#2775) install copyright file into correct location (derailed#2780) fix status for completed pods in workload view (derailed#2729) update deps [Maint] Bump grype rev K9s/release v0.32.5 (derailed#2740) --- (derailed#2707) fix view sorting being reset (derailed#2736) use policy/v1 instead of policy/v1beta1 (derailed#2732) Bump alpine from 3.19.1 to 3.20.0 (derailed#2721) fix: jump to namespaceless owner reference (derailed#2718) feat: Add plugins for argo-rollouts (derailed#2711) Bump golangci/golangci-lint-action from 5.1.0 to 6.0.1 (derailed#2702) allow jumping to the owner of the resource (derailed#2700) fix: job color based on failures (derailed#2686) (derailed#2698) ...
Describe the bug
On the
Jobsview for aCronJob, the jobs that are failed (the ones on the bottom of the below screenshot) look the same as the running one (on the top on the below screenshot).This is erroneous in my opinion, as the color red should not be used for non-failed resources.
To Reproduce
Steps to reproduce the behavior:
CronJobwith some failed and some successful and a running jobCronJoband "enter" it to show its list ofJobsExpected behavior
I expect the running, non-failed
Jobto be shown in a different color than red - blue or green perhaps?Screenshots
Versions (please complete the following information):
The text was updated successfully, but these errors were encountered: