refactor: have all packages extend tsconfig from root#1297
Conversation
|
From the test failures. Looks like needs to havewith { type: 'json' }; added to the import.
Then the playwright things seem to be failing due to code coverage. I have no idea why the changes here would impact the Playwright tests, unless they overlap with the CLI bit somehow. If the coverage data does show overlap for Playwright, we should address it here. Otherwise I'd lower the threshold slightly. I don't think the 2% is a big problem right now for that area. |
|
Ya, what's even weirder is that odd changes to the root |
|
Very interesting. I'll try to check things out in the morning based on wherever you end up tonight. I'm too tired after my day to have any more useful brain energy right now. |
| "allowJs": true, | ||
| "declaration": true, | ||
| "esModuleInterop": true, | ||
| "lib": ["dom", "esnext"], | ||
| "strict": true, | ||
| "module": "esnext", | ||
| "moduleResolution": "node", | ||
| "noImplicitAny": true, | ||
| "noImplicitThis": true, | ||
| "outDir": "dist", | ||
| "pretty": true, | ||
| "removeComments": true, | ||
| "resolveJsonModule": true, | ||
| "skipLibCheck": true, | ||
| "sourceMap": true, | ||
| "declaration": true, | ||
| "outDir": "dist", | ||
| "esModuleInterop": true, | ||
| "resolveJsonModule": true | ||
| "strict": true, | ||
| "strictNullChecks": true, | ||
| "target": "esnext" |
There was a problem hiding this comment.
Thank you for putting these in alphabetical order!
Garbee
left a comment
There was a problem hiding this comment.
LGTM from the last batch of changes and our discussion in slack. Thanks for getting a comment in from that before I could.
Continuing to clean up the repo a bit and having all
tsconfigfiles extend from the root one. Also expanded the roottsconfigto have more strict options. Doing so revealed a type issue in cli when we tried to analyze the page and get the node style callback back so I changed the type to use a control flow analysis for dependent parameters which resolved the issue. This let me remove the type casts of the parameters and use what the function returned.No QA required