Conversation
chutchins25
approved these changes
Feb 20, 2026
chutchins25
left a comment
chutchins25
left a comment
There was a problem hiding this comment.
Looks good to me. Simple enough. Always interesting when there is a dependency that is not included.
Merged
straker
pushed a commit
that referenced
this pull request
Mar 5, 2026
The lockfile got out of sync, in a very odd way. I think npm broke something in a minor in relation to how lockfiles get generated. ## The Problem When [jsonLd](#1280) was updated, something about it [broke the builds](https://github.com/dequelabs/axe-core-npm/actions/runs/22229286256/job/64304204390). But only after getting up to the publish point. The [Node 24](#1281) upgrade got in fine, because it was probably slightly out of sync with `develop`. ## The Solution Update to latest npm with `npm install -g npm` and then `npm install` to refresh the lockfile. Now encoding shows up. This 100% did not work before with an older NPM. So there is a break somewhere in expectations. I narrowed it down to [npm 11.10.1](https://github.com/npm/cli/releases/tag/v11.10.1) that is where `encoding` started to get pulled in. Due to some "hosting" in that changelog, I'm wondering if this is a break from them moving dependencies around. No QA Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual upgrade as #1255 was stuck on couldn't resolve conflicts.
No QA required