ci(deploy): update to oidc tokens#1239
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the deployment workflow from using npm token secrets to OIDC tokens for enhanced security. It also adds conditional npm version upgrades to ensure npm 11 is available when needed, and pins external action versions using commit hashes for better security and reproducibility.
- Replaced npm token authentication with OIDC-based authentication
- Added conditional npm 11 upgrade logic to prevent version downgrade
- Pinned action versions using commit hashes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
scottmries
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the use of the old npm token secret to deploy. Replacing it with the requirements to deploy using OIDC tokens. The NPM update is guarded so it only runs when under 11, so future updates beyond 11 in Node aren't accidentally downgraded if we forget to update this in a timely manner.
While here, increased security/stability by pinning the hash to the two external workflows in use.
Fixes: #1238