Skip to content

fix: Optimize AxeBuilder memory usage. #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bensenescu wants to merge 1 commit into from
Closed

fix: Optimize AxeBuilder memory usage. #1151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/playwright/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default class AxeBuilder {
private includes: SerialSelectorList;
private excludes: SerialSelectorList;
private option: RunOptions;
private source: string;
private axeSource: string | undefined;
private legacyMode = false;
private errorUrl: string;

Expand All @@ -35,7 +35,7 @@ export default class AxeBuilder {
this.includes = [];
this.excludes = [];
this.option = {};
this.source = axeSource || source;
this.axeSource = axeSource;
this.errorUrl =
'https://github.com/dequelabs/axe-core-npm/blob/develop/packages/playwright/error-handling.md';
}
Expand Down Expand Up @@ -210,7 +210,7 @@ export default class AxeBuilder {
*/

private script(): string {
return this.source;
return this.axeSource || source;
}

private async runLegacy(context: SerialContextObject): Promise<AxeResults> {
Expand Down