Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Stops manipulate the items attribute itself to render HTML in SOY template #7 #10

Merged
merged 7 commits into from
Feb 13, 2017

Conversation

fernandosouza
Copy link
Collaborator

No description provided.

@fernandosouza
Copy link
Collaborator Author

cc @brunobasto

@brunobasto
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@brunobasto
Copy link
Contributor

Hey @fernandosouza, I think we can improve this by using the new prepareStateForRender so that we can change the Soy template parameter from internalItems back to items. This makes for a nicer API when rendering from the server.

@brunobasto
Copy link
Contributor

Reference: metal/metal.js#181

@brunobasto brunobasto changed the title Uses const instead of var Adds internalItems to fix #7 Jan 31, 2017
@fernandosouza fernandosouza mentioned this pull request Jan 31, 2017
@fernandosouza
Copy link
Collaborator Author

It makes total sense. I'm going to develop the changes.

@fernandosouza
Copy link
Collaborator Author

Branch updated @brunobasto

@fernandosouza fernandosouza changed the title Adds internalItems to fix #7 Stops manipulate the items attribute itself to render HTML in SOY template #7 Jan 31, 2017
@brunobasto
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@brunobasto brunobasto merged commit 56ec6f8 into deprecate:master Feb 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants