Skip to content
This repository has been archived by the owner on Jan 25, 2018. It is now read-only.

Enables travis #8

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Enables travis #8

merged 2 commits into from
Oct 30, 2017

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented Oct 30, 2017

No description provided.

@jbalsas jbalsas added this to the 2.1.0 milestone Oct 30, 2017
@robframpton robframpton merged commit 5db03a6 into develop Oct 30, 2017
@robframpton
Copy link
Contributor

It looks like the tests are failing due to a regression in metal-state.

metal/metal.js@2c50c73#diff-0aee89f1c625f93fd4bfd8a5e3bbfb99R275

Essentially if an instance of Drag is created before an instance of DragDrop, the DragDrop instance's constructor will already have hasConfiguredState_ set to true. Meaning the state never gets configured.

I'll look into a workaround for metal-drag-drop for now, but this should be addressed in metal-state.

@robframpton
Copy link
Contributor

Confirmed that rolling back the metal dependencies to 2.5.0 resolved the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants