Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies #27

Merged

Conversation

naterminch
Copy link
Contributor

update
"kysely": "^0.27.2", "@planetscale/database": "^1.14.0"

to fix type issue of mysql adapter.

@jacobwgillespie
Copy link
Member

@naterminch hey, thanks for this - what type issue are you seeing? The dependencies you've updated here are devDependencies and won't exist in the published npm package, so I'm not sure that this PR will actually fix the error.

@naterminch
Copy link
Contributor Author

naterminch commented Feb 6, 2024

Hi, Its a minor issue. After i updated the dependencies, i got a type error here.

"@planetscale/database": "^1.15.0",
    "kysely": "^0.27.2",
    "kysely-planetscale": "^1.4.0",

Screenshot 2024-02-05 at 7 57 12 PM

I updated the dependency, built it locally and import to my project. It resolves the type error.

@jacobwgillespie jacobwgillespie merged commit b511a90 into depot:main Feb 6, 2024
@jacobwgillespie
Copy link
Member

Cool - yeah in your case, I think the act of importing them locally likely bumped the dependency versions in your lockfile. Currently the package specifies * as the version selector for peer dependencies which should allow for any version of those dependencies, but it's possible for package managers to end up having multiple versions of kysely when you upgrade the one your app is using, rather than upgrading both your app's version and this package's peer version.

If this happens again, you may want to try running [npm|yarn|pnpm] dedupe, to make the package manager unify your app's chosen kysely version with the peer dependency here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants