Skip to content

Conversation

@DannyvdSluijs
Copy link
Contributor

@DannyvdSluijs DannyvdSluijs commented Jul 15, 2024

  • Bug fix #…?
  • New feature?
  • BC breaks?
  • Tests added: Yes, add a case for importing an invalid schema as that touches on the json-schema integration.
  • Docs added?

This Draft PR is part of the smoke testing of the json-schema v6 release. The smoke testing entails seeing if any issues arise when updating the biggest (by stars) dependencies to the v6.0.0-beta. Obviously this should not be merged in this state, but the pipeline results might help us catch any issues early on.

The question for now would be to approve the pipeline in order to see the results.

Running this test in isolation caused issues when calling Deployer::get() as the underlying $instance was still uninitialised
… smoke testing as part of the version 6 release of json-schema
@antonmedv
Copy link
Member

So can we try to update?

@DannyvdSluijs
Copy link
Contributor Author

So can we try to update?

We are planning to release the v6 soon. Once available I can update this PR to use ^6.0 as a proper constraint.
I can see the pipeline is green so there are no blockers ATM. Doing the same with some other larger dependant packages to ensure we are comfortable with the official release.

@Seb33300
Copy link

Seb33300 commented Oct 3, 2024

@DannyvdSluijs DannyvdSluijs closed this by deleting the head repository Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants