refactor(shopware): Optimize getPlugins to use json output
#3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schrank
reviewed
Feb 16, 2024
|
Thank you so much for taking care of that. It is on my list for months. |
|
And please regenerate the doc: Please, regenerate docs by running next command: Thanks! :) |
Refactoring the `getPlugins` function to not parse regular commandline output anymore, instead use the --json flag `plugin:list`. Refactoring 'sw:plugin:update:all' to not upgrade every installed plugin, but every installed plugin that in fact is upgradable.
mralexandernickel
force-pushed
the
master
branch
from
161d915 to
005c4d3
Compare
|
@Schrank so, I've removed the explode (obviously^^), and used these changes within a real projects deployment, looking good to me. And I've also updated the docs 😊 And thank you very much for your effort on this project! ❤ |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the
getPluginsfunction to not parse regular commandline output anymore, instead use the --json flagplugin:list. Refactoring 'sw:plugin:update:all' to not upgrade every installed plugin, but every installed plugin that in fact is upgradable.Bug fix #…?
New feature?
BC breaks?
Tests added?
Docs added?