-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using an alternate fs for lookup of sources #68
Conversation
Yep good reminder on the docs. I'll update those before the end. |
Forward integrated with master branch and resolved a couple conflicts. |
I've added a test to verify |
Tests passing.
- This won't pass until dependents/node-module-lookup-amd#26 is merged and node-module-lookup dep is updated
@mrjoelkemp
I assume the require call means that node will resolve it on disk - meaning it will bypass the opportunity of going through an alternative |
@dazinator You can probably read it from your fs then json parse it. |
Webpack enhanced resolve has now been updated to support passing a custom fs in: |
note to self: update to latest release of enhanced-resolve to provide custom fs implementation: https://www.npmjs.com/package/enhanced-resolve |
Opening this early, work is still in progress. Closes #65
fs
implementation to be passed toCabinet
inoptions
.options.fileSystem
Then for each resolver, it should honour using alternative
fs
if provided for access to sources:fs
at all, just examines path strings.