Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and drop Node.js < 18 support #60

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 9, 2024

There's a test failure in https://github.com/dependents/detective-typescript/blob/cf5ccf12744dc03bf830a789018f1d13c300c3a5/index.js#L80C9-L80C75

Any help is welcome to fix the issue so that we can update the deps

@waivital
Copy link
Contributor

waivital commented Apr 9, 2024

In this commit, @typescript-eslint/typescript-estree made updates to the structure of TSImportType. Specifically, it removed the parameter and isTypeOf attributes and replaced them with the term argument. Applying the following changes will make the test pass again.

       case 'TSImportType': {
-        if (!skipTypeImports && node.parameter.type === 'TSLiteralType') {
-          dependencies.push(node.parameter.literal.value);
+        if (!skipTypeImports && node.argument.type === 'TSLiteralType') {
+          dependencies.push(node.argument.literal.value);
         }

@XhmikosR
Copy link
Member Author

XhmikosR commented Apr 9, 2024

Thanks a lot @waivital !

@waivital
Copy link
Contributor

waivital commented Apr 9, 2024

Glad to help😄

@XhmikosR XhmikosR marked this pull request as ready for review April 9, 2024 15:33
@XhmikosR XhmikosR merged commit 486de56 into main Apr 9, 2024
7 checks passed
@XhmikosR XhmikosR deleted the xmr/dev branch April 9, 2024 15:34
@XhmikosR
Copy link
Member Author

XhmikosR commented Apr 9, 2024

Released as v12.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants