Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: callback on file #48

Merged
merged 8 commits into from
May 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ const dependencies = detective(mySourceCode);
- `mixedImports`: (default: `false`) Include CJS imports in dependency list
- `skipAsyncImports`: (default: `false`) Whether or not to omit async imports (import('foo'))
- `jsx`: (default: `false`) Enable parsing of JSX
- `onFile`: A callback that will be called before the file is processed. Intended for use with [`dependency-tree`](https://github.com/dependents/node-dependency-tree). Passed an object argument with properties `options` (echoing any options passed in, e.g., by [`precinct`](https://github.com/dependents/node-precinct)), `src` (source code for file as string), `ast` (parsed AST object for the file source), and `walker` (a `Walker` instance from [`source-walk`](https://github.com/dependents/node-source-walk) configured for TypeScript to which you can pass the `ast` or `src`).
- `onAfterFile`: Similar to `onFile`, but the callback is also passed an object property `dependencies`, a string array with the extracted dependencies.

## License

Expand Down
12 changes: 12 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ module.exports = (src, options = {}) => {
const walker = new Walker(walkerOptions);
const dependencies = [];

// Pre-parse the source to get the AST to pass to `onFile`,
// then reuse that AST below in our walker walk.
const ast = typeof src === 'string' ? walker.parse(src) : src;

if (options.onFile) {
options.onFile({ options, src, ast, walker });
}

walker.walk(src, node => {
switch (node.type) {
case 'ImportExpression': {
Expand Down Expand Up @@ -100,6 +108,10 @@ module.exports = (src, options = {}) => {
}
});

if (options.onAfterFile) {
options.onAfterFile({ options, src, ast, walker, dependencies });
}

return dependencies;
};

Expand Down
41 changes: 41 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,47 @@ describe('detective-typescript', () => {
assert.equal(deps[0], 'mylib');
});

it('calls onFile callback', () => {
let onFileCalledArgs;
const onFile = (...args) => {
onFileCalledArgs = args;
};

const src = 'import {foo, bar} from "mylib";';

detective(src, { onFile });

assert.ok(onFileCalledArgs);
assert.ok(onFileCalledArgs[0]);
assert.equal(onFileCalledArgs[0].src, src);
assert.ok(typeof onFileCalledArgs[0].ast === 'object');
assert.ok(typeof onFileCalledArgs[0].walker === 'object');

assert.ok(typeof onFileCalledArgs[0].options === 'object');
assert.equal(onFileCalledArgs[0].options.onFile, onFile);
});

it('calls onAfterFile callback', () => {
let onAfterFileCalledArgs;
const onAfterFile = (...args) => {
onAfterFileCalledArgs = args;
};

const src = 'import {foo, bar} from "mylib";';

detective(src, { onAfterFile });

assert.ok(onAfterFileCalledArgs);
assert.ok(onAfterFileCalledArgs[0]);
assert.equal(onAfterFileCalledArgs[0].src, src);
assert.ok(typeof onAfterFileCalledArgs[0].ast === 'object');
assert.ok(typeof onAfterFileCalledArgs[0].walker === 'object');
assert.ok(Array.isArray(onAfterFileCalledArgs[0].dependencies));

assert.ok(typeof onAfterFileCalledArgs[0].options === 'object');
assert.equal(onAfterFileCalledArgs[0].options.onAfterFile, onAfterFile);
});

it('retrieves the re-export dependencies of modules', () => {
const deps = detective('export {foo, bar} from "mylib";');
assert.equal(deps.length, 1);
Expand Down