Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to select whether filename or filepath is used #749

Merged
merged 5 commits into from
Jan 20, 2023
Merged

Ability to select whether filename or filepath is used #749

merged 5 commits into from
Jan 20, 2023

Conversation

jenspopp
Copy link
Contributor

This is a small change to add a configuration switch for file path usage.
Background: I'm using the plugin to upload and comment owasp checks for multiple servers. It is tedious to search for the files on the server, if there is a new vulnerability.
With this switch the Vulnerability Text contains the filepath from json instead of the filename.

Default behavior does not change

@Reamer
Copy link
Member

Reamer commented Jan 20, 2023

The code looks good. Unfortunately it appears that you use tabs. Please change this to spaces.

Copy link
Member

@Reamer Reamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reamer Reamer merged commit ce3c1c7 into dependency-check:master Jan 20, 2023
@Reamer
Copy link
Member

Reamer commented Jan 31, 2023

@jenspopp We have missed the documentation part. Could you please open a new pull request that adds the documentation in the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants