fix: disable central analyzer after failures #7993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
core
Collaborator
|
Is 2 failed batches in a row (after retries) what you normally abort on? is it affected by parallel processing? (E.g each thread would need 2 consecutive batch failures?) |
chadlwilson
approved these changes
Oct 1, 2025
Collaborator
Author
|
Parallel processing would just have a few searches running at the same time - if one failed, it would prevent other searches from starting up. |
aikebah
previously approved these changes
Oct 1, 2025
Collaborator
aikebah
left a comment
aikebah
left a comment
There was a problem hiding this comment.
Given the current level of (in)stability indeed a better choice to disable it on errors.
Only a few style-related review remarks you might want to address before merging.
core/src/main/java/org/owasp/dependencycheck/analyzer/CentralAnalyzer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/owasp/dependencycheck/analyzer/CentralAnalyzer.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Due to the stability of Cental Search - this PR reduces the retry count and will disable the analyzer after failures.
Related issues