Add a smoke test for a grouped bundler PR#47
Merged
Conversation
Member
|
Exciting! It would be good to hook this up in workflows as well. You can look at this PR for reference: #45 |
Contributor
Author
|
@jakecoffman Done, thanks for the head's up! |
jakecoffman
approved these changes
Mar 23, 2023
Member
jakecoffman
left a comment
jakecoffman
left a comment
There was a problem hiding this comment.
Looks like you need to regenerate the test again, some of the metadata has changed. Then we can merge it and run the Cache One workflow to get the calls cached!
Contributor
Author
|
Ah, there's a randomisation issue I think, we just discussed removing the random order for grouped update so I'll do that and fix it. |
brrygrdn
force-pushed
the
brrygrdn/add-grouped-update-smoke-test
branch
from
6847794 to
415e0de
Compare
Contributor
Author
|
Ah, it was not the randomisation at all - the PR body is stable, you were right some metadata had changed, but I also added the Will merge and cache now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a regression test for the feature/experiment introduced in dependabot/dependabot-core#6884
Before this can merge, #46 needs to be merged as I used it as the base sha for this test and dependabot/dependabot-core#6884 needs to merge in core so this test can be expected to pass when used against the core repo.