Skip to content

Bump nuget files type strictness#8468

Merged
JamieMagee merged 1 commit intomainfrom
jamiemagee/type-nuget
Nov 27, 2023
Merged

Bump nuget files type strictness#8468
JamieMagee merged 1 commit intomainfrom
jamiemagee/type-nuget

Conversation

@JamieMagee
Copy link
Copy Markdown
Member

This change bumps the type strictness for the files added in #8179. That PR was started before Sorbet was added to the codebase, so it's expected that they started as #typed: false.

The bump was performed automatically with bundle exec spoom bump --from=false --to=true nuget.

@JamieMagee JamieMagee requested a review from a team as a code owner November 27, 2023 17:24
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Nov 27, 2023
@deivid-rodriguez
Copy link
Copy Markdown
Contributor

Oh, nice catch @JamieMagee, thanks!

@JamieMagee JamieMagee enabled auto-merge November 27, 2023 17:24
@deivid-rodriguez
Copy link
Copy Markdown
Contributor

Should we be detecting this automatically before merge?

@jurre
Copy link
Copy Markdown
Member

jurre commented Nov 27, 2023

bundle exec spoom bump --from=false --to=true

Yeah maybe we can run bundle exec spoom bump --from=false --to=true and assert it outputs nothing in CI?

@JamieMagee
Copy link
Copy Markdown
Member Author

JamieMagee commented Nov 27, 2023

Should we be detecting this automatically before merge?

It might be possible if you were to run spoom bump as part of CI and exit if there are any files listed?

EDIT: Jurre beat me to it 😅

@JamieMagee JamieMagee merged commit abfcdcf into main Nov 27, 2023
@JamieMagee JamieMagee deleted the jamiemagee/type-nuget branch November 27, 2023 17:30
@jurre
Copy link
Copy Markdown
Member

jurre commented Nov 27, 2023

Should we be detecting this automatically before merge?

It might be possible if you were to run spoom bump as part of CI and exit if there are any files listed?

JINX

@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: dotnet:nuget NuGet packages via nuget or dotnet sorbet 🍦 Relates to Sorbet types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants