-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Contribute changes to NuGet updater from Azure team #8179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
deivid-rodriguez
merged 86 commits into
dependabot:main
from
brettfo:dev/brettfo/nuget-clean
Nov 27, 2023
Merged
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
52fe589
Update implicit nuget dependencies
jmarolf ebb9581
Updated nuget.config to only have one package source url
jmarolf 81d91e3
Add custom nuget updater tool
brettfo 23fabaf
Run unit tests on built container
brettfo 4896f97
Add Binding Redirects
jmarolf 3145e62
Don't overwrite sdk ProjectReference version unless it's an exact match
brettfo 8779840
Also look for proj files in repo folder
jmarolf a511c00
Do not create PRs in unsupported scenarios
jmarolf 527f1e3
Add unit tests for `app.config`/`web.config` binding redirects.
brettfo bdd191d
NuGet: Adds the ability to update version properties
JoeRobich e03d634
NuGet: Add support for GlobalPackageVersion and VersionOverride
JoeRobich 0bfa0f3
Reset repo files after run of NuGet updater
JoeRobich 73bdd32
Update peer dependencies along with primary and only update if TFM is…
brettfo 8921a83
Update NuGet FileFetcher to look for .proj files
JoeRobich 7e82121
Include analyzer packages when calculating dependencies.
JoeRobich fdde9bd
Normalize updated content after running NuGetUpdater
JoeRobich 41a1d42
Refactored NuGetUpdater code.
JoeRobich c2e7887
Fixed typo in moved code.
JoeRobich a45d5f5
Revert logic for file path
brbayes-msft c64abc8
Enhance update_checker to also return peer dependencies
JoeRobich 15ae2bb
Make vulnerable transient NuGet packages top-level
JoeRobich a4c7364
Fix up_to_date check for transient dependency
JoeRobich a3e5428
Refactor NuGetUpdater CLI tool to better support sub-commands
JoeRobich 7cfbe03
Update update_checker to only return compatible package versions
JoeRobich 3b37b7a
Improve top-level dependency and tfm lookup
JoeRobich 798ed6a
Always run the NuGet SdkUpdater.
JoeRobich 87633f3
Update NuGet package compatibility check
JoeRobich dc98736
Fix path normalization
JoeRobich fdc346f
Handle additional azure url feed formats
JoeRobich f4298b2
Only update peer dependencies whose version is too low
JoeRobich 1af8ae8
Adds test for adding a binding redirect. Fixes indentation issues
JoeRobich 55b4e55
Update SdkUpdater to pin transitive dependencies when able.
JoeRobich 11901b0
Remove platform version when parsing NuGetFramework from TFM
JoeRobich 48f6d35
Fix package compatibility check
JoeRobich ce2fdfa
Improve compatibility check and add caching
JoeRobich 217977f
Use include? instead of contains? when checking for substring
JoeRobich 662fcd8
Fix NuGet.config resolution and copying when determining dependencies.
JoeRobich d3ca18a
Disable parsing global.json and dotnet-tools.json until updates are s…
JoeRobich 464f367
Handle nil being returned for project reference path.
JoeRobich 4038f90
Update vcr cassettes
JoeRobich acaa750
When fixing up BOM compare updated content with the original dependen…
JoeRobich da1e055
fix: use negative lookbehind for newline matching
JamieMagee f852b70
Support exact version match NuGet syntax
JoeRobich fa4f465
Fix issues where NuGet dependencies can't be found.
brettfo 40dccba
use xpath to parse build files to allow for invalid msbuild xml
brettfo b63903b
Encapsulate build file logic into separate types.
JoeRobich 24e7cc7
Add dotnet-tools.json and global.json support
JoeRobich 2f92621
Use `msbuild /pp` to preprocess project files
brettfo e47e0c8
don't return duplicate files based on relative paths
brettfo 7194acb
report specific error if submodule is not present
brettfo d33746d
Clean up commented ruby tests
ryanbrandenburg 25da041
lock dependency to specific version
brettfo 1985b1d
Allow non-building projects to be scanned
brettfo c071646
Fix path computation of projects from solution files
brettfo e26a267
Dedup all files based on their absolute path
brettfo 2a4259a
Update existing pinned package version
brettfo 250c98a
Use exact version matching when calculating package dependencies
brettfo c70c24e
Retain comments when updating JSON build files
brettfo edc5c57
Fix edge cases in json comment retainer
brettfo 0dd3b8a
Embed all resources in all NuGet projects
brettfo 4c2f995
Use `NuGetVersion` instead of `SemanticVersion` to allow 4-part versi…
brettfo 55b64ef
Remove unused requires
deivid-rodriguez ff82a3e
Remove VCR from UpdateChecker::VersionFinder specs
deivid-rodriguez 3025ae3
Make spec file runnable in isolation
deivid-rodriguez a83d43f
Remove VCR from UpdateChecker specs
deivid-rodriguez a6d2448
Remove VCR from FileParser specs
deivid-rodriguez a81792b
bin/tapioca gem
deivid-rodriguez b9f33a3
Remove VCR from FileParser::ProjectFileParser specs
deivid-rodriguez 1cf84db
Remove VCR from TfmFinder specs
deivid-rodriguez 4f17949
Move vcr tag to the spec using it
deivid-rodriguez b9c764d
Remove file fetcher edge case
deivid-rodriguez 2a1594a
Prefer `.each` to `.map` since return value is ignored
deivid-rodriguez 701e69d
Fix duplicated files issues when using dry-run from macOS
deivid-rodriguez 2bdb0e3
remove contribution line from README
brettfo 51439a3
Install native helpers as dependabot user
deivid-rodriguez 9e52a39
Also mount nuget helpers in dev image
deivid-rodriguez c2fdf1e
Cleanup native helpers path
deivid-rodriguez 1c93d46
Install dotnet to a more standard location
deivid-rodriguez 38f006c
Move native helper built tool inside /opt/nuget
deivid-rodriguez 23e8e3d
Allow nuget/helpers/build to also install native helpers
deivid-rodriguez 34562a7
Don't make tmp world-writable
deivid-rodriguez 1e1ca56
Introduce final new lines and remove BOMs
deivid-rodriguez 870910b
Add a new smoke test for nuget
deivid-rodriguez ebb50cb
include build-only packages in dependency list
brettfo 57c0f85
improve property handling around the `Condition` attribute
brettfo 38d5044
report specific error if no changes were made
brettfo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "nuget/helpers/lib/NuGet.Client"] | ||
| path = nuget/helpers/lib/NuGet.Client | ||
| url = https://github.com/NuGet/NuGet.Client | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| if [ -z "$DEPENDABOT_NATIVE_HELPERS_PATH" ]; then | ||
| echo "Unable to build, DEPENDABOT_NATIVE_HELPERS_PATH is not set" | ||
| exit 1 | ||
| fi | ||
|
|
||
| helpers_dir=$(cd -P "$(dirname "${BASH_SOURCE[0]}")" && pwd) | ||
|
|
||
| if [ ! -f "$helpers_dir/lib/NuGet.Client/NuGet.sln" ]; then | ||
| echo "NuGet.sln not found; please run 'git submodule update --init --recursive' and try again" | ||
| exit 1 | ||
| fi | ||
|
|
||
| install_dir="$DEPENDABOT_NATIVE_HELPERS_PATH/nuget" | ||
| mkdir -p "$install_dir" | ||
|
|
||
| cp -r \ | ||
| "$helpers_dir/lib" \ | ||
| "$install_dir" | ||
|
|
||
| os="$(uname -s | tr '[:upper:]' '[:lower:]')" | ||
| arch=$(dpkg --print-architecture) | ||
| if [ "$arch" = "amd64" ]; then | ||
| arch="x64" | ||
| fi | ||
|
|
||
| echo "building NuGetUpdater tool" | ||
| cd "$install_dir/lib/NuGetUpdater/NuGetUpdater.Cli" | ||
| dotnet publish \ | ||
| --configuration Release \ | ||
| --output "$install_dir/NuGetUpdater" \ | ||
| --framework net7.0 \ | ||
| --runtime "$os-$arch" | ||
| dotnet clean | ||
|
|
||
| echo "verifying NuGetUpdater tool" | ||
| "$install_dir/NuGetUpdater/NuGetUpdater.Cli" --version |
Submodule NuGet.Client
added at
b46f5f
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.