Skip to content

Fixing Yarn1 erroring with failed to replace env #7767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
honeyankit merged 2 commits into from
Aug 9, 2023
Merged

Fixing Yarn1 erroring with failed to replace env #7767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f412bb
Fixing Yarn1 erroring on parent npmrc files with undefined vars
honeyankit Aug 8, 2023
642c17b
removed unwanted spaces
honeyankit Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/yarn_lockfile_updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,9 +380,10 @@ def clean_npmrc_in_path(yarn_lock)
dirs.pop
while dirs.any?
npmrc = dirs.join("/") + "/.npmrc"
break unless File.exist?(npmrc)
Copy link
Copy Markdown
Contributor

@abdulapopoola abdulapopoola Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was breaking and not walking through the entire dirs right?

Copy link
Copy Markdown
Contributor Author

@honeyankit honeyankit Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If the subdir did not contain the .npmrc file then it was breaking out. In such case if the repo root dir still had .npmrc file then error was getting raised.


File.write(npmrc, File.read(npmrc).gsub(/\$\{.*\}/, ""))
if File.exist?(npmrc)
# If the .npmrc file exists, clean it
File.write(npmrc, File.read(npmrc).gsub(/\$\{.*?\}/, ""))
end
dirs.pop
end
end
Expand Down