fix PR unable to create with grouped updates#7753
Merged
jakecoffman merged 6 commits intomainfrom Aug 8, 2023
Merged
Conversation
honeyankit
approved these changes
Aug 7, 2023
Member
Author
|
Actually this won't fix it because the dependabot-api appends additional data to the end of the message. I'll leave this open though, we might want to ship truncation at this level anyway as we're going to discard the additional message data either way. Might as well shed some sooner? |
jeffwidman
approved these changes
Aug 7, 2023
Member
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
I vote ship this as well because it provides a code tie-in to the other code here in core... ie, if someone is grep'ing for usages they'll see it's used in the updater/cloud/grouped updates work...
jurre
approved these changes
Aug 8, 2023
jurre
force-pushed
the
jakecoffman/fix-group-max-length
branch
from
f7f21c4 to
bf35a85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7743
We're seeing large updates that have large PR bodies fail to create on GitHub with a 422. I think this is due to this change moving the truncation from the
PullRequestCreator.createto theMessageBuilder, and also we started recently using theMessageBuilderhere in theDependencyChangeclass. It didn't get the new truncation settings passed in.For now I copy-pasted the PullRequestCreator's new switch case to add in the limit to get PRs flowing again. This code seems like it could use a refactor.