[Grouped Updates] Don't instantiate any groups without the feature flag#7557
Merged
[Grouped Updates] Don't instantiate any groups without the feature flag#7557
Conversation
brrygrdn
changed the title
jurre
approved these changes
Jul 13, 2023
brrygrdn
force-pushed
the
brrygrdn/refactor-dependency-group-engine
branch
from
e7804f5 to
15beeeb
Compare
Base automatically changed from
brrygrdn/refactor-dependency-group-engine
to
main
July 14, 2023 11:32
brrygrdn
force-pushed
the
brrygrdn/guard-group-eval-with-experiment
branch
from
167601d to
0d141f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes made in #7548 we have a clear touch-point as to when groups are hydrated from the configuration at job startup.
This follows up on that to correct and oversight where the feature flag / experiment for grouped updates didn't stop us attempting to interpret your group config if the feature was disabled.
At this point we're in public beta so this experiment is generally true in production but this reduces the splash radius for anyone using the CLI and ensures that the feature flag is a proper circuit breaker if we need to turn things off temporarily.