[Updater] Wire up and flesh out branch naming for Grouped Update PRs#7084
Merged
[Updater] Wire up and flesh out branch naming for Grouped Update PRs#7084
Conversation
brrygrdn
force-pushed
the
brrygrdn/finalise-dependency-group-branch-naming
branch
3 times, most recently
from
28f7a77 to
ca5705c
Compare
Nishnha
reviewed
Apr 14, 2023
Member
There was a problem hiding this comment.
nit: I think it would make sense to update GROUP_NAME_PLACEHOLDER here to "all-dependencies". Otherwise branch names will pop up with a *
Contributor
Author
There was a problem hiding this comment.
Good spot, yep, we should be consistent
Contributor
Author
There was a problem hiding this comment.
Ah, I've actually realised we don't use this name to generate the branch name as API is the one that actually generates the object that gets used.
I'm going to leave this as-is for now to avoid CI churn, etc as we should yoink this placeholder out once #7075 merges
Nishnha
approved these changes
Apr 14, 2023
Member
Nishnha
left a comment
Nishnha
left a comment
There was a problem hiding this comment.
The tests are pretty comprehensive, thanks!
Had one minor nit around the name of the default dependency group, but the actual branch name changes LGTM
brrygrdn
force-pushed
the
brrygrdn/finalise-dependency-group-branch-naming
branch
from
ca5705c to
0193c77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have spiked out using
DependencyGroupin branch naming but in our internal tests we are overriding theprefixvalue for projects in order to work around potential naming collisions since the prototype cannot yet manage superseding of existing pull requests.Before we go into the next round of testing, we should make our branch naming for grouped PRs more compatible with existing automation and also avoid problems of the branch name overflowing due to a larger-than-normal number of dependencies being involved.
This PR finishes off our grouped naming strategy so it incorporates the normal prefix, the package manager, directory and target branch along with the actual group name being used.