Skip to content

[Updater] Prefer updated_dependencies to dependencies for DependencyChange objects#7005

Merged
brrygrdn merged 1 commit intomainfrom
brrygrdn/fix-dependency-change-language
Apr 6, 2023
Merged

[Updater] Prefer updated_dependencies to dependencies for DependencyChange objects#7005
brrygrdn merged 1 commit intomainfrom
brrygrdn/fix-dependency-change-language

Conversation

@brrygrdn
Copy link
Copy Markdown
Contributor

@brrygrdn brrygrdn commented Apr 5, 2023

This is a change I split out from #7004 as it was a fairly significant diff already.

DependencyChange currently has a dependencies attribute, but this will always be a the set of dependencies updated as part of the change the object describes. Since dependencies is heavily saturated, I've changed the interface to make this updated_dependencies so the nature and state of this list is as explicit as possible.

@brrygrdn brrygrdn requested a review from a team as a April 5, 2023 13:39
@brrygrdn brrygrdn force-pushed the brrygrdn/extract-dependency-change-creation branch 3 times, most recently from 0c03bf2 to a52e2bd Compare April 6, 2023 11:01
Base automatically changed from brrygrdn/extract-dependency-change-creation to main April 6, 2023 12:10
@brrygrdn brrygrdn force-pushed the brrygrdn/fix-dependency-change-language branch from 3936df2 to 25d2ad3 Compare April 6, 2023 12:13
@brrygrdn brrygrdn merged commit f7c4ee2 into main Apr 6, 2023
@brrygrdn brrygrdn deleted the brrygrdn/fix-dependency-change-language branch April 6, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants