Skip to content

run all CI on Gemfile or Gemfile.lock change#6857

Merged
jakecoffman merged 5 commits intomainfrom
jakecoffman/run-workflow-on-gemfile-change
Mar 17, 2023
Merged

run all CI on Gemfile or Gemfile.lock change#6857
jakecoffman merged 5 commits intomainfrom
jakecoffman/run-workflow-on-gemfile-change

Conversation

@jakecoffman
Copy link
Copy Markdown
Member

One of our tests starting failing out of nowhere and slowed us down a bit. We found this was due to a fairly minor Octokit change in #6826.

To catch this sort of thing sooner, we should be running all CI whenever the updater Gemfile or lock changes.

I wasn't sure if updater/Gemfile* would pick up both, so I opted for updater/Gemfil*.

@jakecoffman jakecoffman requested a review from a team as a code owner March 16, 2023 20:09
@Nishnha
Copy link
Copy Markdown
Member

Nishnha commented Mar 16, 2023

The filters managed by this action: https://github.com/dorny/paths-filter

Not sure if the * glob is supported but might as well try it out?

@Nishnha Nishnha force-pushed the jakecoffman/run-workflow-on-gemfile-change branch from c84d558 to f98da5a Compare March 16, 2023 20:20
@Nishnha
Copy link
Copy Markdown
Member

Nishnha commented Mar 16, 2023

Rebased the branch so it includes the changes from #6855

@jakecoffman jakecoffman enabled auto-merge (squash) March 17, 2023 13:05
@jakecoffman jakecoffman merged commit bfed956 into main Mar 17, 2023
@jakecoffman jakecoffman deleted the jakecoffman/run-workflow-on-gemfile-change branch March 17, 2023 13:43
@jakecoffman jakecoffman mentioned this pull request Mar 21, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants