Fix retrieval of private registry metadata from the Job definition#6843
Merged
Fix retrieval of private registry metadata from the Job definition#6843
Conversation
jakecoffman
approved these changes
Mar 15, 2023
brrygrdn
force-pushed
the
brrygrdn/fix-private-reg-from-job-def
branch
from
d541263 to
6d786a0
Compare
1 task
Contributor
Author
|
This patch does not seem to have fully solved the issue, taking another look at it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #6810
The modified code in this PR attempted to retrieve the
credential-metadatausing the wrong key name by confuting the pre- and post-standardisation use of kebab- and snake-case respectively, i.e.credential_metadatainstead.This change reverts to the original call order to ensure that the retrieval happens after standardisation to guard against any future changes to key manipulation leaving the credential_metadata clause out of alignment with the rest of the payload.