Do not nil out the PR message for jobs updating a PR#6813
Merged
Conversation
pavera
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #6792.
The newly introduced
DependencyChangeclass made an assumption that any content created as result of a Job which hadupdating_a_pull_request?should not generate apr_messageobject as the ApiClient historically did not accept apr_messageargument.In reality, we have this scenario when
updating_a_pull_request?is true to consider:dependabot-core/updater/lib/dependabot/updater.rb
Lines 196 to 201 in a196e04
In a scenario where we close the existing PR and create a new one, the
nilPR message blocks the API accepting the request.