Rely on previously-defined constant#6801
Conversation
landongrindheim
force-pushed
the
rely-on-previously-defined-constant
branch
from
48e8995 to
0ef723f
Compare
.github/workflows/smoke.yml
Outdated
There was a problem hiding this comment.
This should not make it into the default branch. It's pointing to a branch which holds the expected output of this branch's concerns. I'm open to input re: whether it should remain as part of commit history.
There was a problem hiding this comment.
☝️ was a proof-of-concept wherein I updated the redirect URL in the smoke-tests repo. This is the resulting build result 👇
I'll be removing that ref now.
|
What's the difference between the two URLs? |
Ah, looks like |
Nishnha
left a comment
Nishnha
left a comment
There was a problem hiding this comment.
Thanks for showing that e2e tests are passing on the use-redirect-dot-github branch.
This LGTM
The DEFAULT_GITHUB_REDIRECTION_SERVICE has been the default argument for PullRequestCreator, but I think it can also serve the same purpose in PullRequestCreator::MessageBuilder.
This commit is pointing to a branch which should be short-lived. It is a proof-of-concept to show smoke tests passing under new conditions, and is not meant to be the final state of the workflow.
This was meant to be temporary, as a proof-of-concept which could show that tests were passing once the new endpoint was used.
landongrindheim
force-pushed
the
rely-on-previously-defined-constant
branch
from
812e87f to
b90d2d9
Compare
2 participants
The DEFAULT_GITHUB_REDIRECTION_SERVICE has been the default argument for PullRequestCreator, but I think it can also serve the same purpose in PullRequestCreator::MessageBuilder.