Skip to content

Go: fix NilClass error when directory doesn't have a go.mod file#6763

Merged
jakecoffman merged 1 commit intomainfrom
jakecoffman/no-go-mod
Mar 2, 2023
Merged

Go: fix NilClass error when directory doesn't have a go.mod file#6763
jakecoffman merged 1 commit intomainfrom
jakecoffman/no-go-mod

Conversation

@jakecoffman
Copy link
Copy Markdown
Member

@jakecoffman jakecoffman commented Mar 2, 2023 •
edited
Loading

Fixes NoMethodError error introduced just now in #6658

NoMethodError
undefined method `content' for nil:NilClass

            "gomod" => go_mod.content.match(/^go\s(\d+\.\d+)/)&.captures&.first || "unknown"

This is being caused by misconfigured dependabot.yml where go.mod is not present in the directory. I'm kind of surprised we don't raise an exception sooner since it's listed in required_files_in?.

@jakecoffman jakecoffman requested a review from a team as a code owner March 2, 2023 15:52
landongrindheim
landongrindheim approved these changes Mar 2, 2023
View reviewed changes
@jakecoffman jakecoffman merged commit ca5e17d into main Mar 2, 2023
@jakecoffman jakecoffman deleted the jakecoffman/no-go-mod branch March 2, 2023 18:01
@jeffwidman jeffwidman mentioned this pull request Mar 2, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mctofu mctofu mctofu approved these changes

@landongrindheim landongrindheim landongrindheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakecoffman @mctofu @landongrindheim