-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make gradle display_name property use full dependency name #6526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
What you've got looks good, but I realized while reviewing that these can be quite verbose, so we'll probably need to cap a max length... should be trivial to implement, but gimme a day or two to collect more info for #3353 (comment).
@mrwhoknows55 want to pick one of these solutions and run with it?:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Can you fix the lint failures? https://github.com/dependabot/dependabot-core/actions/runs/4025933944/jobs/6925118702 For the line too long, I'm fine if you disable that check for that line, IMO the point is to have a long package name...
I suspect the smoke test failure is because the smoke test needs updating to match the new expected behavior--I can handle that post merge. |
I went ahead and fixed the lints so we could land this. |
In dependabot/dependabot-core#6526, the display name for Gradle was updated to include the full name. See that PR for rationale. Updated the smoke test by finding the image name from: https://github.com/dependabot/dependabot-core/actions/runs/4034930902/attempts/1#summary-10953476551 And then running: ```shell dependabot --updater-image ghcr.io/dependabot/dependabot-updater-gradle:5eff30823a1eb0aba02f2267d14427a8bb547414 test -f tests/smoke-gradle.yaml -o tests/smoke-gradle.yaml ``` And committing the diff.
I fixed the failing smoke test in dependabot/smoke-tests#27. |
In dependabot/dependabot-core#6526, the display name for Gradle was updated to include the full name. See that PR for rationale. Updated the smoke test by finding the image name from: https://github.com/dependabot/dependabot-core/actions/runs/4034930902/attempts/1#summary-10953476551 And then running: ```shell dependabot --updater-image ghcr.io/dependabot/dependabot-updater-gradle:5eff30823a1eb0aba02f2267d14427a8bb547414 test -f tests/smoke-gradle.yaml -o tests/smoke-gradle.yaml ``` And committing the diff.
Make Gradle `display_name` property use full dependency name if less than 100 chars long. --------- Co-authored-by: Jeff Widman <[email protected]>
closes #3353