Skip to content

prevent "unknown" base_commit SHA from failing PR creation #6266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakecoffman merged 2 commits into from
Dec 5, 2022
Merged

prevent "unknown" base_commit SHA from failing PR creation #6266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7d8921
prevent "unknown" base_commit SHA from failing PR creation
jakecoffman Dec 5, 2022
5ace0dc
Merge branch 'main' into jakecoffman/base-commit-sanity-checks
jakecoffman Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion updater/lib/dependabot/file_fetcher_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ def perform_job
begin
connectivity_check if ENV["ENABLE_CONNECTIVITY_CHECK"] == "1"
clone_repo_contents
@base_commit_sha = file_fetcher.commit || "unknown"
@base_commit_sha = file_fetcher.commit
raise "base commit SHA not found" unless @base_commit_sha

dependency_files
rescue StandardError => e
@base_commit_sha ||= "unknown"
Expand Down