Skip to content

Delay short-circuit in dry-run.rb if vulnerable #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffwidman merged 1 commit into from
Dec 5, 2022
Merged

Delay short-circuit in dry-run.rb if vulnerable #6258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bin/dry-run.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,11 +679,6 @@ def security_fix?(dependency)
next
end

if checker.up_to_date?
puts " (no update needed as it's already up-to-date)"
next
end

if checker.vulnerable?
if checker.lowest_security_fix_version
puts " => earliest available non-vulnerable version is " \
Expand All @@ -693,6 +688,11 @@ def security_fix?(dependency)
end
end

if checker.up_to_date?
puts " (no update needed as it's already up-to-date)"
next
end

latest_allowed_version = if checker.vulnerable?
checker.lowest_resolvable_security_fix_version
else
Expand Down